Re: [PATCH] net: tc35815: Fix phydev supported/advertising mask

From: David Miller
Date: Mon Apr 27 2020 - 14:52:35 EST


From: Anthony Felice <tony.felice@xxxxxxxxxxx>
Date: Sun, 26 Apr 2020 22:00:59 -0400

> Commit 3c1bcc8614db ("net: ethernet: Convert phydev advertize and
> supported from u32 to link mode") updated ethernet drivers to use a
> linkmode bitmap. It mistakenly dropped a bitwise negation in the
> tc35815 ethernet driver on a bitmask to set the supported/advertising
> flags.
>
> Found by Anthony via code inspection, not tested as I do not have the
> required hardware.
>
> Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
> Signed-off-by: Anthony Felice <tony.felice@xxxxxxxxxxx>
> Reviewed-by: Akshay Bhat <akshay.bhat@xxxxxxxxxxx>

Applied.