Re: [PATCH] net: tc35815: Fix phydev supported/advertising mask

From: Andrew Lunn
Date: Mon Apr 27 2020 - 08:37:57 EST


On Sun, Apr 26, 2020 at 10:00:59PM -0400, Anthony Felice wrote:
> Commit 3c1bcc8614db ("net: ethernet: Convert phydev advertize and
> supported from u32 to link mode") updated ethernet drivers to use a
> linkmode bitmap. It mistakenly dropped a bitwise negation in the
> tc35815 ethernet driver on a bitmask to set the supported/advertising
> flags.
>
> Found by Anthony via code inspection, not tested as I do not have the
> required hardware.
>
> Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
> Signed-off-by: Anthony Felice <tony.felice@xxxxxxxxxxx>
> Reviewed-by: Akshay Bhat <akshay.bhat@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Thanks.

Andrew