Re: On trace_*_rcuidle functions in modules

From: John Stultz
Date: Wed Apr 15 2020 - 20:06:50 EST


On Wed, Apr 15, 2020 at 3:51 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> I was about to suggest a patch, but that has already been written...
>
> 313c8c16ee62b ("PM / CPU: replace raw_notifier with atomic_notifier")
>
> Which surrounds the notifier callbacks with rcu_irq_enter_irqson()
>
> Which means that if John moves the code to use the notifier, then he could
> also remove the _rcuidle(), because RCU will be watching.

So you're saying the recent change to move to using trace_*_rcuidle()
was unnecessary?

Or is there a different notifier then cpu_pm_register_notifier() that
the driver should be using (that one seems to be using
atomic_notifier_chain_register())?

thanks
-john