Re: [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema

From: Rob Herring
Date: Fri Mar 27 2020 - 15:30:05 EST


On Fri, Mar 27, 2020 at 11:04:00AM +0100, Linus Walleij wrote:
> Hi Lubomir!
>
> Excellent work! Just nitpicks:
>
> On Tue, Mar 17, 2020 at 10:40 AM Lubomir Rintel <lkundrak@xxxxx> wrote:
>
> > +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> > @@ -0,0 +1,173 @@
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/mrvl-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell PXA GPIO controller
>
> This binding is lacking a license. Please use the dual GPL+BSD license
> tag.

That is preferred, but should only be dual if you have rights on the old
binding file or get relicensing permissions.

>
> > +maintainers:
> > + - devicetree@xxxxxxxxxxxxxxx
>
> I don't know if Robert Jarzmik is in on maintaining this, would you accept
> it Robert?
>
> Yours,
> Linus Walleij