Re: [PATCH v2 3/3] spi: sprd: spi: sprd: Add DMA mode support

From: Baolin Wang
Date: Wed Feb 13 2019 - 07:35:24 EST


On Wed, 13 Feb 2019 at 20:20, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Wed, Feb 13, 2019 at 03:36:11PM +0800, Baolin Wang wrote:
>
> > +enum sprd_spi_dma_channel {
> > + SPI_RX,
> > + SPI_TX,
> > + SPI_MAX,
> > +};
>
> It'd have been better to namespace these (SPRD_SPI_ or something) in
> case of conflicts. That's really minor though and everything else looks
> good so I'll go ahead and apply, thanks!

Yes, I'll send one incremental patch ASAP. Thanks for your reviewing.

--
Baolin Wang
Best Regards