Re: [PATCH v2 3/3] spi: sprd: spi: sprd: Add DMA mode support

From: Mark Brown
Date: Wed Feb 13 2019 - 07:20:29 EST


On Wed, Feb 13, 2019 at 03:36:11PM +0800, Baolin Wang wrote:

> +enum sprd_spi_dma_channel {
> + SPI_RX,
> + SPI_TX,
> + SPI_MAX,
> +};

It'd have been better to namespace these (SPRD_SPI_ or something) in
case of conflicts. That's really minor though and everything else looks
good so I'll go ahead and apply, thanks!

Attachment: signature.asc
Description: PGP signature