Re: [PATCHv4 5/6] drm/omap: add framedone interrupt support

[Sebastian Reichel]

Hi,

On Sat, Nov 17, 2018 at 10:08:40PM +0100, Pavel Machek wrote:
> > This prepares framedone interrupt handling for
> > manual display update support.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> 
> Acked-by: Pavel Machek <pavel@xxxxxx>

Thanks.

> > @@ -217,6 +239,9 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
> >  
> >  		if (irqstatus & priv->dispc_ops->mgr_get_sync_lost_irq(priv->dispc, channel))
> >  			omap_crtc_error_irq(crtc, irqstatus);
> > +
> > +		if (irqstatus & priv->dispc_ops->mgr_get_framedone_irq(priv->dispc, channel))
> > +			omap_crtc_framedone_irq(crtc, irqstatus);
> >  	}
> >  
> >  	omap_irq_ocp_error_handler(dev, irqstatus);
> 
> Will the mgr_get_framedone_irq(priv->dispc, channel) change from
> interrupt to interrupt? Would it make sense to cache result as a
> micro-organization?

Maybe. But this is the same for the the omap_crtc_error_* and the
driver is currently being restructured by Laurent. I think this can
wait for later.

-- Sebastian

Attachment: signature.asc
Description: PGP signature