Re: [PATCHv4 5/6] drm/omap: add framedone interrupt support

From: Pavel Machek
Date: Sat Nov 17 2018 - 16:08:48 EST


Hi!

> This prepares framedone interrupt handling for
> manual display update support.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

Acked-by: Pavel Machek <pavel@xxxxxx>

> @@ -217,6 +239,9 @@ static irqreturn_t omap_irq_handler(int irq, void *arg)
>
> if (irqstatus & priv->dispc_ops->mgr_get_sync_lost_irq(priv->dispc, channel))
> omap_crtc_error_irq(crtc, irqstatus);
> +
> + if (irqstatus & priv->dispc_ops->mgr_get_framedone_irq(priv->dispc, channel))
> + omap_crtc_framedone_irq(crtc, irqstatus);
> }
>
> omap_irq_ocp_error_handler(dev, irqstatus);

Will the mgr_get_framedone_irq(priv->dispc, channel) change from
interrupt to interrupt? Would it make sense to cache result as a
micro-organization?

Thanks,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature