Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD

From: David Woodhouse
Date: Tue Sep 18 2018 - 09:33:02 EST


On Tue, 2018-09-18 at 15:03 +0200, Peter Zijlstra wrote:
> > > In original code, it will go to "call *%[thunk_target]\n" while
> > > we have set SPECTRE_V2_RETPOLINE_MINIMAL or
> > > SPECTRE_V2_RETPOLINE_MINIMAL_AMD. Is this expected?
> >
> > Yes, that is exactly right -- it does that with or without your change
> > though.
>
> Soryr, I wrote that before I noticed the CONFIG_RETPOLINE vs RETPOLINE
> thing.
>
> In any case, since retpoline capable compilers are widely available, I'm
> all for making CONFIG_RETPOLINE hard depend on it. That minimal stuff
> really is quite silly.

Yep, now the the compiler support is widespread that makes a lot of
sense.

Attachment: smime.p7s
Description: S/MIME cryptographic signature