Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD

From: Peter Zijlstra
Date: Tue Sep 18 2018 - 09:03:34 EST


> > In original code, it will go to "call *%[thunk_target]\n" while
> > we have set SPECTRE_V2_RETPOLINE_MINIMAL or
> > SPECTRE_V2_RETPOLINE_MINIMAL_AMD. Is this expected?
>
> Yes, that is exactly right -- it does that with or without your change
> though.

Soryr, I wrote that before I noticed the CONFIG_RETPOLINE vs RETPOLINE
thing.

In any case, since retpoline capable compilers are widely available, I'm
all for making CONFIG_RETPOLINE hard depend on it. That minimal stuff
really is quite silly.