Re: [PATCH v2] mtd: rawnand: tegra: check bounds of die_nr properly

From: Miquel Raynal
Date: Wed Jul 18 2018 - 03:45:59 EST


Hi Marcel,

Marcel Ziswiler <marcel@xxxxxxxxxxxx> wrote on Tue, 17 Jul 2018
10:46:18 +0200:

> From: Stefan Agner <stefan@xxxxxxxx>
>
> The Tegra driver currently only support a single chip select, hence
> check boundaries accordingly. This fixes a off by one issue catched
> with Smatch:
> drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip()
> warn: array off by one? 'nand->cs[die_nr]'
>
> Also warn in case the stack asks for a chip select we currently do
> not support.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>

Applied on nand/next in place of the previous one (with my SoB after
yours).

Thanks,
MiquÃl