RE: [PATCH net-next 7/9] net: hns3: Fix for reset_level default assignment probelm

[Salil Mehta]

Hi Sergei,

> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Sergei Shtylyov
> Sent: Tuesday, July 17, 2018 10:37 AM
> To: Salil Mehta <salil.mehta@xxxxxxxxxx>; davem@xxxxxxxxxxxxx
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@xxxxxxxxxx>; lipeng (Y)
> <lipeng321@xxxxxxxxxx>; mehta.salil@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Linuxarm <linuxarm@xxxxxxxxxx>;
> linyunsheng <linyunsheng@xxxxxxxxxx>
> Subject: Re: [PATCH net-next 7/9] net: hns3: Fix for reset_level
> default assignment probelm
> 
> Hello!
> 
> On 7/16/2018 6:36 PM, Salil Mehta wrote:
> 
> > From: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> >
> > handle->reset_level is assigned to HNAE3_NONE_RESET when client is
> > initialized, if a tx timeout happens right after initialization,
> > then handle->reset_level is not resetted to HNAE3_FUNC_RESET in
> 
>     s/resetted/reset/.

Thanks for looking through. Will take care in future submissions.

Best regards
Salil
> 
> > hclge_reset_event, which will cause reset event not properly
> > handled problem.
> >
> > This patch fixes it by setting handle->reset_level properly when
> > client is initialized.
> >
> > Fixes: 6d4c3981a8d8 ("net: hns3: Changes to make enet watchdog
> timeout func common for PF/VF")
> > Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> > Signed-off-by: Peng Li <lipeng321@xxxxxxxxxx>
> > Signed-off-by: Salil Mehta <salil.mehta@xxxxxxxxxx>
> [...]
> 
> MBR, Sergei