Re: [PATCH] selftests: remove obsolete kconfig fragment for cpu-hotplug

From: Shuah Khan
Date: Thu Nov 02 2017 - 18:14:25 EST


Hi Lei,

On 10/17/2017 08:10 PM, lei.yang@xxxxxxxxxxxxx wrote:
> From: Lei Yang <Lei.Yang@xxxxxxxxxxxxx>

Are you using git send-email to send patches. it is odd to see this
extra From: line.

>
> Kconfig CONFIG_CPU_NOTIFIER_ERROR_INJECT has been removed since kernel 4.10
> check commit:
> commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
> Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Date: Wed Dec 21 20:19:53 2016 +0100
>
> cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions
>
> hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(),
> register_hotcpu_notifier(), register_cpu_notifier(),
> __register_hotcpu_notifier(), __register_cpu_notifier(),
> unregister_hotcpu_notifier(), unregister_cpu_notifier(),
> __unregister_hotcpu_notifier(), __unregister_cpu_notifier()
> <snip>

Please make sure your commit lines are 75 chars or less. Make sure you
run chekpatch script on your patches.

I fixed these when I applied the patch. No need to resend this patch.
Please make sure to use git send-email and run checkpatch script on
your future patches.

>
> Signed-off-by: Lei Yang <Lei.Yang@xxxxxxxxxxxxx>

Applied to linux-kselftest next for 4.15-rc1.

> ---
> tools/testing/selftests/cpu-hotplug/config | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cpu-hotplug/config b/tools/testing/selftests/cpu-hotplug/config
> index e6ab090..d4aca2a 100644
> --- a/tools/testing/selftests/cpu-hotplug/config
> +++ b/tools/testing/selftests/cpu-hotplug/config
> @@ -1,2 +1 @@
> CONFIG_NOTIFIER_ERROR_INJECTION=y
> -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
>

thanks,
-- Shuah