Re: [PATCH] selftests: remove obsolete kconfig fragment for cpu-hotplug

From: Greg Kroah-Hartman
Date: Thu Nov 02 2017 - 04:46:48 EST


On Wed, Nov 01, 2017 at 04:14:54PM -0600, Shuah Khan wrote:
> On 10/17/2017 08:10 PM, lei.yang@xxxxxxxxxxxxx wrote:
> > From: Lei Yang <Lei.Yang@xxxxxxxxxxxxx>
> >
> > Kconfig CONFIG_CPU_NOTIFIER_ERROR_INJECT has been removed since kernel 4.10
> > check commit:
> > commit 530e9b76ae8f863dfdef4a6ad0b38613d32e8c3f
> > Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Date: Wed Dec 21 20:19:53 2016 +0100
> >
> > cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions
> >
> > hotcpu_notifier(), cpu_notifier(), __hotcpu_notifier(), __cpu_notifier(),
> > register_hotcpu_notifier(), register_cpu_notifier(),
> > __register_hotcpu_notifier(), __register_cpu_notifier(),
> > unregister_hotcpu_notifier(), unregister_cpu_notifier(),
> > __unregister_hotcpu_notifier(), __unregister_cpu_notifier()
> > <snip>
> >
> > Signed-off-by: Lei Yang <Lei.Yang@xxxxxxxxxxxxx>
> > ---
> > tools/testing/selftests/cpu-hotplug/config | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/cpu-hotplug/config b/tools/testing/selftests/cpu-hotplug/config
> > index e6ab090..d4aca2a 100644
> > --- a/tools/testing/selftests/cpu-hotplug/config
> > +++ b/tools/testing/selftests/cpu-hotplug/config
> > @@ -1,2 +1 @@
> > CONFIG_NOTIFIER_ERROR_INJECTION=y
> > -CONFIG_CPU_NOTIFIER_ERROR_INJECT=m
> >
>
> Yes. It is removed from the kernel. However, selftests from the latest
> release do get run routinely on older stable releases. Dropping the
> config will impact coverage on older releases.
>
> Thomas/Greg,
>
> Any ideas on what we should do about this. On one hand it is a good idea
> to remove it, however my concern is coverage on older releases.

If this is a kernel-internal-api/function test, yeah, just remove it, no
need to keep it around. The idea of keeping something like this around
wouldn't make much sense.

thanks,

greg k-h