Re: [PATCH 4.9 000/105] 4.9.55-stable review

From: David Miller
Date: Thu Oct 12 2017 - 13:17:05 EST


From: Xin Long <lucien.xin@xxxxxxxxx>
Date: Thu, 12 Oct 2017 23:25:10 +0800

> pls try revert:
> commit 02f7e4101092b88e57c73171174976c8a72a3eba
> Author: Eric Dumazet <edumazet@xxxxxxxxxx>
> Date: Mon Oct 2 12:20:51 2017 -0700
>
> socket, bpf: fix possible use after free
>
> which caused a obvious issue in __sk_attach_prog():
> atomic_set(&fp->refcnt, 0); <----
>
> if (!sk_filter_charge(sk, fp)) {
> kfree(fp);
> return -ENOMEM;
> }

Yeah this is the bad patch, my backport was buggy.

Greg, please revert.