Re: [PATCH 4.9 000/105] 4.9.55-stable review

From: Ben Hutchings
Date: Thu Oct 12 2017 - 13:09:12 EST


On Thu, 2017-10-12 at 10:54 -0600, Shuah Khan wrote:
> On 10/12/2017 09:35 AM, Shuah Khan wrote:
> > On 10/12/2017 09:25 AM, Xin Long wrote:
> > > On Thu, Oct 12, 2017 at 11:18 PM, Andreas Radke
> > > <andreas.radke@xxxxxxxxxxx> wrote:
> > > > Building the 4.9.x kernel package for Arch Linux 4.9.55 gives
> > > > this IPv4 error here:
[...]
> > > > Okt 12 17:09:38 server64 dhcpd[638]: Can't install packet
> > > > filter program: Cannot allocate memory
[...]
> > > pls try revert:
> > > commit 02f7e4101092b88e57c73171174976c8a72a3eba
> >
> > Correction. The commit is:
> >
> > 345c66695569db83eed100723e4df72cb54df7de
> >
> > I will try the revert and let you know.
>
> okay reverting the
>
> commit 345c66695569db83eed100723e4df72cb54df7de
> Author: Eric Dumazet <edumazet@xxxxxxxxxx>
> Date:ÂÂÂMon Oct 2 12:20:51 2017 -0700
>
> ÂÂÂÂsocket, bpf: fix possible use after free
> ÂÂÂÂ
> ÂÂÂÂ
> ÂÂÂÂ[ Upstream commit eefca20eb20c66b06cf5ed09b49b1a7caaa27b7b ]
[...]
> fixes the issue. Looks like this is a fix for another problem.

It seems to depend on:

commit 4c355cdfbba537971b5c3849680b1b6453a7a383
Author: Reshetova, Elena <elena.reshetova@xxxxxxxxx>
Date:ÂÂÂTue Mar 21 13:59:19 2017 +0200

ÂÂÂÂnet: convert sk_filter.refcnt from atomic_t to refcount_t

That split up sk_filter_charge() so that the refcount initialisation
won't trip the increment-from-zero check.

Ben.

> Anyway - I have 4.9.55 - minus
> 345c66695569db83eed100723e4df72cb54df7de
> running now with networking operational.
>
> thanks,
> -- Shuah
>
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.