Re: [PATCH 3/4] sparc: bpf_jit: Avoid assignment for "flen" if BPF JIT is disabled

From: Daniel Borkmann
Date: Sat Sep 03 2016 - 12:58:26 EST


On 09/03/2016 06:40 PM, SF Markus Elfring wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 3 Sep 2016 18:00:03 +0200

Move the assignment for the local variable "flen" a bit at the beginning
so that it will only be performed if BPF JIT is enabled for this function.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Why is that a particular issue (did you measure some improvement when
you say "fine-tuning" as per subject) ?

That's all not in critical path here by the way, same for patch 2.