[PATCH 3/4] sparc: bpf_jit: Avoid assignment for "flen" if BPF JIT is disabled

From: SF Markus Elfring
Date: Sat Sep 03 2016 - 12:41:24 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 3 Sep 2016 18:00:03 +0200

Move the assignment for the local variable "flen" a bit at the beginning
so that it will only be performed if BPF JIT is enabled for this function.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
arch/sparc/net/bpf_jit_comp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c
index a927470..a6b6e29 100644
--- a/arch/sparc/net/bpf_jit_comp.c
+++ b/arch/sparc/net/bpf_jit_comp.c
@@ -365,13 +365,14 @@ void bpf_jit_compile(struct bpf_prog *fp)
unsigned int cleanup_addr, proglen, oldproglen;
u32 temp[8], *prog, *func, seen, pass;
const struct sock_filter *filter;
- int i, flen = fp->len, pc_ret0;
+ int i, flen, pc_ret0;
unsigned int *addrs;
void *image;

if (!bpf_jit_enable)
return;

+ flen = fp->len;
addrs = kmalloc_array(flen, sizeof(*addrs), GFP_KERNEL);
if (addrs == NULL)
return;
--
2.9.3