Re: [PATCH 1/2] net: ethernet: ethoc: use phydev from struct net_device

From: Tobias Klauser
Date: Mon Jun 27 2016 - 02:42:10 EST


On 2016-06-25 at 16:33:41 +0200, Philippe Reynes <tremyfr@xxxxxxxxx> wrote:
> The private structure contain a pointer to phydev, but the structure
> net_device already contain such pointer. So we can remove the pointer
> phy in the private structure, and update the driver to use the
> one contained in struct net_device.

In that case the phy member should also be removed from the definition
of private struct ethoc in the same patch.

Otherwise the patch looks good to me.