Re: linux-next: build warning after merge of the pci tree

From: Johannes Thumshirn
Date: Fri Jun 24 2016 - 04:08:16 EST


On Thu, Jun 23, 2016 at 11:48:49AM -0500, Bjorn Helgaas wrote:
> On Thu, Jun 23, 2016 at 11:51:54AM +1000, Stephen Rothwell wrote:
> > Hi Bjorn,
> >
> > After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/misc/genwqe/card_base.c: In function 'genwqe_pci_remove':
> > drivers/misc/genwqe/card_base.c:1155:6: warning: unused variable 'bars' [-Wunused-variable]
> > int bars;
> > ^
> > drivers/misc/genwqe/card_base.c: In function 'genwqe_pci_setup':
> > drivers/misc/genwqe/card_base.c:1143:2: warning: 'bars' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > pci_release_selected_regions(pci_dev, bars);
> > ^
> >
> > Introduced by commit
> >
> > 370b01694826 ("GenWQE: Use pci_(request|release)_mem_regions")
>
> Thanks, Stephen. I made the following edits, which should resolve these
> warnings. Johannes, let me know if they look right to you.
>

Looks good, thanks.
Johannes

--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850