Re: [PATCH] rtc: s5m: De-inline large functions to save space

From: Alexandre Belloni
Date: Tue Feb 23 2016 - 18:15:50 EST


On 16/02/2016 at 11:04:42 +0900, Krzysztof Kozlowski wrote :
> Few functions were marked inline even though they were relatively large
> and sometimes used in multiple places. De-inline them to let the
> compiler decide whether optimization makes sense. This fixes inline_hunt
> report:
> drivers/rtc/rtc-s5m.c: Deinline s5m8767_rtc_set_alarm_reg, save 704 bytes
> drivers/rtc/rtc-s5m.c: Deinline s5m8767_wait_for_udr_update, save 192 bytes
>
> Reported-by: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
> Cc: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
> drivers/rtc/rtc-s5m.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com