Re: [PATCH] drivers/rtc: make class.c explicitly non-modular

From: Alexandre Belloni
Date: Tue Feb 23 2016 - 18:13:37 EST


On 14/02/2016 at 15:04:19 -0500, Paul Gortmaker wrote :
> The Makefile/Kconfig currently controlling compilation of this code is:
>
> obj-$(CONFIG_RTC_CLASS) += rtc-core.o
> rtc-core-y := class.o interface.o
>
> drivers/rtc/Kconfig:menuconfig RTC_CLASS
> drivers/rtc/Kconfig: bool "Real Time Clock"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the code there is no doubt it is builtin-only.
>
> We don't replace module.h with init.h since the file does need
> to know what a struct module is.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> Cc: rtc-linux@xxxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
> drivers/rtc/class.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com