Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

[Andy Shevchenko]

On Fri, Jan 22, 2016 at 2:05 PM, MÃns RullgÃrd <mans@xxxxxxxxx> wrote:
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>> On Fri, 2016-01-22 at 11:13 +0000, MÃns RullgÃrd wrote:
>>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>>> > On Wed, 2016-01-20 at 20:07 +0000, MÃns RullgÃrd wrote:
>>> > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:

>> +               u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ?    \
>> +                          _dwc->p_master : _dwc->m_master;                     \
>> +               u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ?    \
>> +                          _dwc->p_master : _dwc->m_master;                     \

> Oh, I see it now.  Two lines have a space rather than a tab since a tab
> would push them over 80 columns.  Now those lines could be shortened by
> simply dropping the "_is_slave" since this is necessarily true if the
> other half of the && is.

Yes, direction is precisely from the _is_slave space.

-- 
With Best Regards,
Andy Shevchenko