Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

[Måns Rullgård]

Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:

> On Fri, 2016-01-22 at 11:13 +0000, MÃns RullgÃrd wrote:
>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>> > On Wed, 2016-01-20 at 20:07 +0000, MÃns RullgÃrd wrote:
>> > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:
>
>> > InÂDWC_DEFAULT_CTLLO() can we do tab indentation for \ ?
>> 
>> Is there a wrong indentation somewhere?ÂÂI don't see it.
>
> My git diff shows this in particular:
>
> --- a/drivers/dma/dw/core.c
> +++ b/drivers/dma/dw/core.c
> @@ -45,10 +45,10 @@
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂDW_DMA_MSIZE_16;ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 _dmsize = _is_slave ? _sconfig->dst_maxburst :ÂÂÂÂÂÂÂ\
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂDW_DMA_MSIZE_16;ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ? \
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ_dwc->p_master : _dwc->m_master;ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ? \
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ_dwc->p_master : _dwc->m_master;ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ?ÂÂÂÂ\
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ_dwc->p_master : _dwc->m_master;ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ?ÂÂÂÂ\
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ_dwc->p_master : _dwc->m_master;ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
>
> Means in your case the ' \' is used, in mine â '\t\' at the end of
> lines.

Oh, I see it now.  Two lines have a space rather than a tab since a tab
would push them over 80 columns.  Now those lines could be shortened by
simply dropping the "_is_slave" since this is necessarily true if the
other half of the && is.

>> Now the question: who do you prefer to submit the series (dw_dmac)?
>> > Me
>> > or you?
>> > 
>> > In case you would like to do it (what I see in your dwc-sata branch
>> > today):
>> > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> 
>> I'll fix the above, give your changes a review, and add my sign-off
>> before sending the series, today or during the weekend.
>
> OK.
>
> Just to be sure we are on the same page. I assume your dwc-sata branch
> as for submitting.

Yes, I'm not aware of anything that needs to change in that branch.

-- 
MÃns RullgÃrd