Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

From: Mark Brown
Date: Wed Dec 23 2015 - 06:42:20 EST


On Wed, Dec 23, 2015 at 11:58:36AM +0100, Paul Kocialkowski wrote:
> Some devices don't hook the DVS pin to a GPIO but to ground or VCC.
> In those cases, it is not a problem to have no DVS GPIO.

I would expect the driver at least needs to know how the pins or
strapped, or otherwise have configuration for ignoring the input on the
pins. This just deletes the warnings, it doesn't have any handling for
this case that I can see.

Attachment: signature.asc
Description: PGP signature