Re: [RFC PATCH 2/9] drm/rockchip: Use new vblank api drm_crtc_vblank_*

From: Mark yao
Date: Tue Dec 01 2015 - 04:43:45 EST


On 2015å12æ01æ 17:01, Daniel Vetter wrote:
On Tue, Dec 01, 2015 at 04:33:27PM +0800, Mark yao wrote:
On 2015å12æ01æ 15:56, Daniel Stone wrote:
Hi,

On 1 December 2015 at 03:26, Mark Yao <mark.yao@xxxxxxxxxxxxxx> wrote:
No functional update, drm_vblank_* is the legacy version of
drm_crtc_vblank_*. and use new api make driver more clean.

Signed-off-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
Heh, I had the same patch in my series to fix pageflip events.

Reviewed-by: Daniel Stone <daniels@xxxxxxxxxxxxx>

Cheers,
Daniel



Hi Daniel
I had picked your patch "[PATCH 1/2] drm/rockchip: Use CRTC vblank event
interface" into my drm-next, this patch is base on it.
That really should be mentioned in the commit message, and you must keep
the signed-off-by chain intact when adapting or reusing other peoples
work.
-Daniel

Oh, Sorry for that, this patch is another patch rebase on Daniel Stone's one, I use "base on it" may be ambiguity.
like that:
0e6919f drm/rockchip: Use new vblank api drm_crtc_vblank_*
4f0cb7c drm/rockchip: Use CRTC vblank event interface

Thanks for pointing that, I will be carefully next time.

Thanks for your review.

--
ïark Yao


_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/