Re: [PATCH 04/10] vfs: Distinguish between full xattr names and proper prefixes

From: James Morris
Date: Tue Dec 01 2015 - 04:43:18 EST


On Mon, 30 Nov 2015, Andreas Gruenbacher wrote:

> Add an additional "name" field to struct xattr_handler. When the name
> is set, the handler matches attributes with exactly that name. When the
> prefix is set instead, the handler matches attributes with the given
> prefix and with a non-empty suffix.
>
> This patch should avoid bugs like the one fixed in commit c361016a in
> the future.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>

Is it worth making an inline wrapper for 'handler->prefix ?:
handler->name' ?


Reviewed-by: James Morris <james.l.morris@xxxxxxxxxx>


--
James Morris
<jmorris@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/