Re: [PATCH] staging: speakup: Used kstrtoul instead of simple_strtoul

From: Greg KH
Date: Sat Sep 12 2015 - 00:35:45 EST


On Fri, Sep 11, 2015 at 06:06:34PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul inorder to fix a warning
> detected by checkpatch.
> The warning is given below:
> drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@xxxxxxxxx>
> ---
> drivers/staging/speakup/kobjects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index 3708bc1..05de0b7 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
> continue;
> }
>
> - index = simple_strtoul(cp, &temp, 10);
> + index = kstrtoul(cp, &temp, 10);
> if (index > 255) {
> rejected++;
> cp = linefeed + 1;
> --
> 1.7.9.5

Never send patches that you yourself did not at least test-build.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/