Re: [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul

From: Greg KH
Date: Sat Sep 12 2015 - 00:35:38 EST


On Fri, Sep 11, 2015 at 08:47:20PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul to remove a warning detected by
> checkpatch.The warning is given below:
> drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@xxxxxxxxx>
> ---
> drivers/staging/speakup/varhandlers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
> index 1b0d1c0..00fd67e 100644
> --- a/drivers/staging/speakup/varhandlers.c
> +++ b/drivers/staging/speakup/varhandlers.c
> @@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
> {
> int val = 0;
>
> - val = simple_strtoul(skip_spaces(start), &start, 10);
> + val = kstrtoul(skip_spaces(start), &start, 10);
> if (*start == ',')
> start++;
> *dest = (u_char)val;

You obviously did not even compile this patch, which is quite rude,
don't you think?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/