Re: [PATCH RFC] crypto: drbg - lower reseed threshold if seed source is degraded

From: Herbert Xu
Date: Tue Jun 09 2015 - 11:33:46 EST


On Tue, Jun 09, 2015 at 05:27:46PM +0200, Stephan Mueller wrote:
>
> I see one: the reset of the threshold to the "normal" value must happen at two
> places: the one place is in the async handler. The 2nd place is when the
> request to random.c returns 0 (i.e. fully initialized). The 2nd location is
> different between both code bases.

Right but after the callback patch there should be only one location
where you reset it to normal, namely in the async handler. The
other place would only set it to the lower value if the pool is
not ready yet.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/