Re: [PATCH RFC] crypto: drbg - lower reseed threshold if seed source is degraded

From: Stephan Mueller
Date: Tue Jun 09 2015 - 11:28:04 EST


Am Dienstag, 9. Juni 2015, 23:26:05 schrieb Herbert Xu:

Hi Herbert,

> On Tue, Jun 09, 2015 at 05:22:32PM +0200, Stephan Mueller wrote:
> > Am Dienstag, 9. Juni 2015, 22:25:25 schrieb Herbert Xu:
> >
> > Hi Herbert,
> >
> > > Anyway, I'm happy to apply this. However, the patch is corrupted
> > > so please resend it without the white-space damage/line wrapping.
> >
> > As this patch would clash with the async seeding patch, shall I develop
> > this patch on top of your async patch set?
>
> Either way is fine. I can fix it up when applying as they don't
> conceptually conflict.

I see one: the reset of the threshold to the "normal" value must happen at two
places: the one place is in the async handler. The 2nd place is when the
request to random.c returns 0 (i.e. fully initialized). The 2nd location is
different between both code bases.
>
> Thanks,


--
Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/