Re: [PATCH] debug: Deprecate BUG_ON() use in new code, introduce CRASH_ON()

From: Ingo Molnar
Date: Mon Jun 08 2015 - 07:29:31 EST



* Alexander Holler <holler@xxxxxxxxxxxxx> wrote:

> > Also note that BUG_ON() will make data corruption _worse_ statistically. Why?
> > Because most data corruptions are unlikely to be perfectly detected by a
> > BUG_ON(), and the BUG_ON() delays the finding of the underlying bug, so the
> > bug will hit more people before it's fixed for good.
> >
> > So even in the cases where you could argue that the system needs to stop,
> > because we have evidence of data corruption, it's statistically the better
> > approach to continue and get kernel log info back to developers.
>
> Risking more, maybe even worse problems like corrupting file systems or similiar
> in order to have a slightly chance of save log info?

That's not what I said - please read my argument and argue with that if you want,
not with some other straw-man argument...

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/