Re: [PATCH 4/6] i2c-parport: use new parport device model

[Wolfram Sang]

> > >  static struct parport_driver i2c_parport_driver = {
> > > -	.name	= "i2c-parport",
> > > -	.attach	= i2c_parport_attach,
> > > -	.detach	= i2c_parport_detach,
> > > +	.name		= "i2c-parport",
> > > +	.match_port	= i2c_parport_attach,
> > > +	.detach		= i2c_parport_detach,
> > > +	.devmodel	= true,
> > 
> > Minor nit: I prefer to not use tabs but a single space after the struct
> > member names. Less hazzle in the future and still readable IMO.
> It was having space originally. I changed that into tab as it was
> looking good with them as aligned.
> I will wait today for some more review and send v2 tomorrow with this
> chanage.

Thanks. Just to make sure: Keep it one space only, no alignment.

Attachment: signature.asc
Description: Digital signature