Re: [PATCH v5 07/10] ARM: dts: Clean up exynos5250-arndale

From: Tomasz Figa
Date: Fri Aug 01 2014 - 17:04:04 EST


Just wanted to report one issue unrelated to your changes I spotted
while reviewing this patch. See below.

On 01.08.2014 06:54, Andreas FÃrber wrote:
> Use the new style of referencing inherited nodes, use symbolic names,
> tidy indentation and reorder includes.
>
> Goal is the alignment of all exynos5250 based device trees for comparison.

[snip]

> - fimd: fimd@14400000 {
> - status = "okay";
> - display-timings {
> - native-mode = <&timing0>;
> - timing0: timing@0 {
> - /* 2560x1600 DP panel */
> - clock-frequency = <50000>;

This apparently makes little sense as I doubt anybody would be willing
to run a DP panel with refresh rate of 0,012 Hz...

Anyway, your patch just moves it, so this is just an unrelated report.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/