Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800Device Driver Support

[Joe Perches]

On Tue, 2014-01-28 at 16:36 +0800, liujunliang_ljl@xxxxxxx wrote:
> From: Liu Junliang <liujunliang_ljl@xxxxxxx>

trivial comments...

> diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c

[]

> +static int sr_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
> +{
[]
> +		if (size != ((~header >> 16) & 0x07ff)) {
> +			netdev_err(dev->net,
> +				   "sr_rx_fixup() Bad Header Length\n");

printks with embedded functions names are
generally better using "%s: ", __func__

			netdev_err(dev->net, "%s: Bad header length\n",
				   __func__);

[]

> +			netdev_err(dev->net,
> +				   "sr_rx_fixup() Bad RX Length %d\n", size);

etc.

> +	if (skb->len != offset) {
> +		netdev_err(dev->net, "sr_rx_fixup() Bad SKB Length %d\n",
> +			   skb->len);

etc.

[]

> +static inline int sr9800_set_default_mode(struct usbnet *dev)
> +{

rather a big function to inline

[]

> +	if (ret < 0) {
> +		netdev_dbg(dev->net, "Write IPG,IPG1,IPG2 failed: %d", ret);

missing newline terminations

> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations",
> +		   rx_ctl);

etc...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/