[PATCH 11/14] NVMe: Factor out nvme_init_bar()

From: Alexander Gordeev
Date: Tue Jan 28 2014 - 03:59:30 EST


Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
---
drivers/block/nvme-core.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index d81b4c4..1e30c42 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -1886,10 +1886,10 @@ static size_t db_bar_size(struct nvme_dev *dev, unsigned nr_io_queues)
return 4096 + ((nr_io_queues + 1) * 8 * dev->db_stride);
}

-static int nvme_setup_io_queues(struct nvme_dev *dev, int nr_io_queues)
+static int nvme_init_bar(struct nvme_dev *dev, int nr_io_queues)
{
struct pci_dev *pdev = dev->pci_dev;
- int result, cpu, i, vecs, size, q_depth;
+ int size;

size = db_bar_size(dev, nr_io_queues);
if (size > 8192) {
@@ -1906,6 +1906,14 @@ static int nvme_setup_io_queues(struct nvme_dev *dev, int nr_io_queues)
dev->queues[0]->q_db = dev->dbs;
}

+ return nr_io_queues;
+}
+
+static int nvme_setup_io_queues(struct nvme_dev *dev, int nr_io_queues)
+{
+ struct pci_dev *pdev = dev->pci_dev;
+ int result, cpu, i, vecs, q_depth;
+
/* Deregister the admin queue's interrupt */
free_irq(dev->entry[dev->queues[0]->cq_vector].vector, dev->queues[0]);

@@ -2420,6 +2428,10 @@ static int nvme_dev_start(struct nvme_dev *dev)
if (result < 0)
goto disable;

+ result = nvme_init_bar(dev, result);
+ if (result < 0)
+ goto disable;
+
result = nvme_setup_io_queues(dev, result);
if (result)
goto disable;
--
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/