Re: [PATCH -tip v6 06/22] [BUGFIX] x86: Prohibit probing on memcpy/memset

From: Masami Hiramatsu
Date: Thu Dec 19 2013 - 21:38:06 EST


Hi Jovi,

(2013/12/19 18:37), Jovi Zhangwei wrote:
> Hi Masami,
>
> On Thu, Dec 19, 2013 at 5:04 PM, Masami Hiramatsu
> <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
>> memcpy/memset functions are fundamental functions and
>> those are involved in kprobe's exception handling.
>> Prohibit probing on them to avoid kernel crash.
>>
> Would you please let me know the LKML link of that bugfix, I cannot
> find it in my LKML fold.

Yeah, that was found in my testing environment.

> No objection on this patch. :) just want to know more, It seems there
> have no problem to probe memcpy in my box, maybe I didn't hit the
> crash code path.

Ah, I see. Originally the problem happened when I put a probe on
__memcpy. And it looks the instances of memcpy and __memcpy are
same on x86-64. Thus I decided to blacklist both. (memset/__memset too)
Have you ever tried to probe __memcpy on your box?

Thank you,

--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/