[PATCH]: exec: avoid propagating PF_NO_SETAFFINITY into userspace child

From: zhang . yi20
Date: Fri Nov 29 2013 - 04:20:12 EST



Khelper is a workqueue thread which has PF_NO_SETAFFINITY set.
When a usermode process is spawned by khelper through __call_usermodehelper()
which will invoke kernel_thread() (not kthread_create()) to fork the new
process, we will clearly see that it will inherit the PF_NO_SETAFFINITY flag.

Consequently, this usermod process will lose some capabilities like
sched_setaffinity(), moving between cgroups, etc.

Clearing this flag in flush_old_exec() to solve this problem.


Signed-off-by: Zhang Yi <zhang.yi20@xxxxxxxxxx>
Signed-off-by: Pang Xunlei <pang.xunlei@xxxxxxxxxx>

--- linux-3.12.old/fs/exec.c 2013-11-26 08:53:12.175811856 +0000
+++ linux-3.12/fs/exec.c 2013-11-27 09:36:56.231972168 +0000
@@ -1090,8 +1090,8 @@ int flush_old_exec(struct linux_binprm *
bprm->mm = NULL; /* We're using it now */

set_fs(USER_DS);
- current->flags &=
- ~(PF_RANDOMIZE | PF_FORKNOEXEC | PF_KTHREAD | PF_NOFREEZE);
+ current->flags &= ~(PF_RANDOMIZE | PF_FORKNOEXEC | PF_KTHREAD |
+ PF_NOFREEZE | PF_NO_SETAFFINITY);
flush_thread();
current->personality &= ~bprm->per_clear;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/