Re: [PATCH 02/16] staging/lustre/llog: MGC to use OSD API for backuplogs

[Peng Tao]

This is a multi-part message in MIME format.On 11/26/2013 11:34 AM, Greg Kroah-Hartman wrote:
> On Tue, Nov 26, 2013 at 11:25:24AM +0800, Peng Tao wrote:
> > On Tue, Nov 26, 2013 at 11:14 AM, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > On Tue, Nov 26, 2013 at 10:04:56AM +0800, Peng Tao wrote:
> > > > From: Mikhail Pershin <mike.pershin@xxxxxxxxx>
> > > >
> > > > MGC uses lvfs API to access local llogs blocking removal of old code
> > > >
> > > > - MGS is converted to use OSD API for local llogs
> > > > - llog_is_empty() and llog_backup() are introduced
> > > > - initial OSD start initialize run ctxt so llog can use it too
> > > > - shrink dcache after initial scrub in osd-ldiskfs to avoid holding
> > > >    data of unlinked objects until umount.
> > >
> > > It is not checkpatch clean :(
> > >
> > > Come on, it's not hard to do this yourself, why do you make me find
> > > these errors for you?  It does nothing but make me not want to look at
> > > lustre patches for a long time...
> >
> > Strange. I did run checkpatch before sending the patchset out.
> >
> > Just tried again. Still pass.
> >
> > [X61@linux-lustre]$./scripts/checkpatch.pl
> > 0002-staging-lustre-llog-MGC-to-use-OSD-API-for-backup-lo.patch total:
> > 0 errors, 0 warnings, 883 lines checked
> >
> > 0002-staging-lustre-llog-MGC-to-use-OSD-API-for-backup-lo.patch has no
> > obvious style problems and is ready for submission.
> >
> > What message did you see?
>
> One about return();
OK. Looks like a latest checkpatch.pl change. After rebasing my working 
copy to latest staging-next, I can see the same error. I'll fix up. 
Sorry for the noise.

Thanks,
Tao