Re: [PATCH 21/22] perf tools: Add trace-event global object fortracepoint interface

From: Jiri Olsa
Date: Mon Nov 25 2013 - 11:04:18 EST


On Sat, Nov 23, 2013 at 12:47:14AM +0900, Namhyung Kim wrote:
> 2013-11-21 (ë), 12:01 +0100, Jiri Olsa:
> > In order to get the proper plugins processing we need to
> > use full trace-event interface when creating tracepoint
> > events. So far we were using shortcut to get the parsed
> > format.
> >
> > Moving current 'event_format__new' function into trace-event
> > object as 'trace_event__tp_format'.
> >
> > This function uses properly initialized global trace-event
> > object, ensuring proper plugins processing.
>
> I see this when I compile it on my old ubuntu 10.04 box (with gcc 4.4.3)
>
> CC util/trace-event.o
> cc1: warnings being treated as errors
> util/trace-event.c: In function 'trace_event__tp_format':
> util/trace-event.c:63: error: not protecting function: no buffer at
> least 8 bytes long
> make[1]: *** [util/trace-event.o] Error 1

hum, what was the stackprotector status?

... stackprotector: [ on ]
... stackprotector-all: [ on ]


thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/