Re: [PATCH] Fixed atleast coding style issues relating spaces

From: Jesper Juhl
Date: Sat Apr 21 2012 - 17:19:25 EST


On Sun, 22 Apr 2012, Jeffrin Jose wrote:

> hello
>
> I have fixed atleast coding style issues relating
> spaces in file sound/usb/card.c
>
> Please see attachment.
>

ok, So I took a quick look at the patch and I think it looks fine. So as
far as that goes, feel free to add
Acked-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

but you really should try to send patches inline rather than as
attachments. Attachments are a pain when you want to reply and quote and
comment on the patch.

As far as the mail (patch) subject goes, I also feel a need to comment;
what's up with "atleast"? Shouldn't it just be
"Fixed coding style issues relating to spaces" ??

Anyway, the actual change looks good to me.

--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/