Re: [PATCH] fs: fix integer overflow in MS_NOUSER definition

From: Al Viro
Date: Sat Apr 21 2012 - 02:28:48 EST

On Sat, Apr 21, 2012 at 09:49:49AM +0400, Konstantin Khlebnikov wrote:
> MS_NOUSER defined as signed int (1<<31), sb->s_flags declared as unsigned long.
> So (sb->s_flags & MS_NOUSER) works as (sb->s_flags & 0xffffffff80000000).

... and it's not a problem since we can't use bits 32 and above anyway -
unsigned long is 32bit on a lot of platforms. I have no objections to
making that 1U<<31, but it's not a bug, let alone an integer overflow.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at