Re: [PATCH v7 1/6] Extcon (external connector): import Android'sswitch class and modify.

From: MyungJoo Ham
Date: Wed Apr 18 2012 - 22:36:43 EST

On Thu, Apr 19, 2012 at 6:47 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Mar 23, 2012 at 05:52:58PM +0900, MyungJoo Ham wrote:
>> External connector class (extcon) is based on and an extension of
>> Android kernel's switch class located at linux/drivers/switch/.
> <snip>
> This patch breaks the build:
> drivers/extcon/extcon_class.c:79:6: error: redefinition of ‘extcon_set_state’
> include/linux/extcon.h:80:20: note: previous definition of ‘extcon_set_state’ was here
> drivers/extcon/extcon_class.c:170:5: error: redefinition of ‘extcon_dev_register’
> include/linux/extcon.h:67:19: note: previous definition of ‘extcon_dev_register’ was here
> drivers/extcon/extcon_class.c:214:6: error: redefinition of ‘extcon_dev_unregister’
> include/linux/extcon.h:73:20: note: previous definition of ‘extcon_dev_unregister’ was here
> So it obviously can't be applied to the tree :(
> Did you test it?
> Care to redo this series and send it again?
> greg k-h


That error is very wierd. It implies that CONFIG_EXTCON is "not
defined" in extcon.h and CONFIG_EXTCON is "defined" in Makefile so
that extcon_class.c is compiled.

However, the patchset v8 (some bugfixes over patchset v7) that is
tested on the base of Linux 3.4-rc3 w/ and w/o CONFIG_EXTCON and has
been used with MAX77693-MUIC devices is on the way.



MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at