Re: [PATCH v7 1/6] Extcon (external connector): import Android'sswitch class and modify.

[Greg KH]

On Thu, Apr 19, 2012 at 08:48:35AM +0900, Kyungmin Park wrote:
> On 4/19/12, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, Apr 19, 2012 at 08:38:06AM +0900, Kyungmin Park wrote:
> >> Hi Greg,
> >>
> >> Can you check the latest extcon at here?
> >>
> >> http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon
> >
> > No, please send me patches, that's what I need to have in order to apply
> > them.
> >
> > Always make sure that your patches do not break the build along the
> > series, which is what happened here.  Did you not test this?
> 
> No, we tested it from kernel 3.2 and generate the patches against the
> latest kernel at that time.

It wasn't an issue about the kernel it was built against, it is a bug in
this first patch, it just will not build.  That needs to be fixed,
right?

> Here's another patch based on 3.3-rc4.
> http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
> 
> Anyway, as you want, we will send the extcon patches again without build break.

That's a requirement if you want them to be applied :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/