Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver

[Grant Likely]

On Fri, Jan 13, 2012 at 12:27:22PM +0100, Michal Simek wrote:
> Alan Stern wrote:
> >On Thu, 12 Jan 2012, Michal Simek wrote:
> >
> >>Drivers shouldn't use NO_IRQ. This driver is used
> >>by Microblaze and PPC. PPC defines NO_IRQ as 0
> >>and Microblaze has removed it.
> >>
> >>Signed-off-by: Michal Simek <monstr@xxxxxxxxx>
> >>CC: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> >>CC: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >>CC: Grant Likely <grant.likely@xxxxxxxxxxxx>
> >>CC: linux-usb@xxxxxxxxxxxxxxx
> >>CC: devicetree-discuss@xxxxxxxxxxxxxxxx
> >>---
> >> drivers/usb/host/ehci-xilinx-of.c |    2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c
> >>index 32793ce..9c2cc46 100644
> >>--- a/drivers/usb/host/ehci-xilinx-of.c
> >>+++ b/drivers/usb/host/ehci-xilinx-of.c
> >>@@ -183,7 +183,7 @@ static int __devinit ehci_hcd_xilinx_of_probe(struct platform_device *op)
> >> 	}
> >> 	irq = irq_of_parse_and_map(dn, 0);
> >>-	if (irq == NO_IRQ) {
> >>+	if (!irq) {
> >> 		printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
> >> 		rv = -EBUSY;
> >> 		goto err_irq;
> >
> >Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 
> Thanks Alan.
> 
> I have seen that Grant sent the same patch to lkml too.
> Here is the thread: http://lkml.org/lkml/2012/1/11/342
> 
> Grant: How fast do you think you are able to merge your patches?

Ignore my patch.  It won't go in until 3.4

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/