Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning messageto include domain id.

From: Konrad Rzeszutek Wilk
Date: Mon Jan 09 2012 - 10:24:48 EST


> > > > - dev_err(&dev->dev, "device has been assigned to another " \
> > > > - "domain! Over-writting the ownership, but beware.\n");
> > > > + dev_err(&dev->dev, "Overriding ownership to dom%d.\n",
> > > > + xen_find_device_domain_owner(dev));
> > >
> > > That sounds like you are going to be assigning the ownership to that
> > > dom, but xen_find_device_domain_owner so aren't you actually steeling
> > > ownership from that domain?
> >
> > Duh! I will do s/to/from/
>
> Maybe s/Overriding/Stealing/ too? "Overriding ownership from xxx" sounds
> a bit odd to me.

Bingo! "Stealing ownership from dom%d." it is!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/