Re: [PATCHv2] dma40: Improve the logic of stopping logical chan

[Linus Walleij]

On Fri, Jan 6, 2012 at 7:13 AM, Narayanan G
<narayanan.gopalakrishnan@xxxxxxxxxxxxxx> wrote:

> From the V2 version of the controller a logical channel
> can be directly stopped by issuing a SUSPEND_REQ on the EE
> bits. There is no need to suspend the physical channel and
> restart it.
>
> Also, the support for pre-V2 hw is discontinued.
>
> EE bits for writing:
>
> 00: disable only if AS=11 or AS=00
> 01: enable
> 10: suspend_req only if AS=01 & EE=01 or EE=11
> 11: round / no change for writing
>
> Signed-off-by: Narayanan G <narayanan.gopalakrishnan@xxxxxxxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

However this looks a bit strange and gives a warning when applying the
patch:

> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index cc5ecbc..8009e8b1 100755

100755?

Did you accidentally execute something like chmod -R 755 ...?

Well, it works fine anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/