Re: [RFC][PATCH 7/7] serial, 8250: Mostly avoid wakeups from underport->lock

From: Alan Cox
Date: Wed Dec 21 2011 - 13:50:52 EST


> > Also I think it's probably buggy - sending the x_char is forward progress
> > so probably needs to cause a wakeup.
>
> Could you explain that more, its not actually connecting with any
> neurons..

The tty output queue is the ring buffer + one byte (x_char). It's
effectively two priority queues one of which is 1 byte long and high
priority, the other of which is low priority.

> > So for the moment NAK, but worthy of figuring out how to do it right
>
> OK, will try and see if I can poke at it a level upwards..

I think that is the right magic - and also means all the embedded
consoles might be poked the right way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/