Re: [PATCH] intel-iommu: Add device info into list before doingcontext mapping

From: Chris Wright
Date: Wed Dec 21 2011 - 13:48:21 EST


* Chris Wright (chrisw@xxxxxxxxxxxx) wrote:
> * Hao, Xudong (xudong.hao@xxxxxxxxx) wrote:
> > Yes, Chris, thanks your comments.
> > How about this one?
>
> Yes, it gets the locking right.

Sorry, I missed one other problem on the error path. You need to also
update pdev->dev.archdata.iommu to NULL (otherwise it is left pointing
to freed memory).

> Also makes host device and guest assigned device go through the same order:
>
> alloc_devinfo and init
> lock; place info on lists; unlock
> domain_context_mapping()
>
> The patch itself is whitespace damaged and does not apply. Please fix
> and feel free to add my:
>
> Acked-by: Chris Wright <chrisw@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/