Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags onerror

[Ingo Molnar]

* Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> > FYI, there's no "I will only sign off on a patch doing two 
> > things if it's applied in full" kind of condition in the SOB 
> > definition, allowing that would break the GPL: people have 
> > the right to take your modifications to the GPL-ed kernel 
> > and modify it further.
> 
> That gets into moral rights, and at least in the EU 
> representing someone as the author of something they are not 
> [..]

Alan, stop being silly - you clearly don't know what you are 
talking about.

The fact is, *every single line of code* in that commit was 
written by Ben Hutchinson. Peter was being excessively helpful, 
polite and did Ben a favor by splitting out the debug-printks 
from the original submission and upstreaming them.

What he did not do was to apply an unrelated, still under 
discussion change mixed into that debug-printouts patch.

Look at the original submission by Ben on lkml:

 Subject: [PATCH 1/2] lockdep,rtmutex,bug: Show taint flags on error

The hunk that Peter left out of that patch was not declared in 
the patch title and was unrelated to the rest of the patch:

--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -233,16 +233,6 @@ unsigned long get_taint(void)

 void add_taint(unsigned flag)
 {
-       /*
-        * Can't trust the integrity of the kernel anymore.
-        * We don't call directly debug_locks_off() because the issue
-        * is not necessarily serious enough to set oops_in_progress to 1
-        * Also we want to keep up lockdep for staging development and
-        * post-warning case.
-        */
-       if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
-               printk(KERN_WARNING "Disabling lock debugging due to kernel taint\n");
-
        set_bit(flag, &tainted_mask);

Criticising Peter for not applying that change which the patch 
title did not even mention and then sulkingly asking the SOB to 
be removed is silly and offensive square two.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/